From ecaf9d6f4ffbc669129d3c0e9de0c3e918f1de2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20PIERRE?= Date: Sun, 12 Jan 2025 01:56:31 +0100 Subject: [PATCH] Deprecate "details" mask. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Many reasons… - it doesn't work - it is so scale-sensitive that it makes the "scale to window" zoom level useless and behaves very differently depending on zoom level - it is designed as a work-around for bad edge-avoidance in frequency modules - that should be fixed in those modules - it samples data at demosaicing step, meaning later distortions mess it up and it's not available for non-raw images - it is broken in many subtle ways. See #394 --- src/develop/blend_gui.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/develop/blend_gui.c b/src/develop/blend_gui.c index b141524268ec..cf54c488b831 100644 --- a/src/develop/blend_gui.c +++ b/src/develop/blend_gui.c @@ -2853,7 +2853,8 @@ void dt_iop_gui_update_blending(dt_iop_module_t *module) } const dt_image_t img = module->dev->image_storage; - gtk_widget_set_visible(bd->details_slider, dt_image_is_rawprepare_supported(&img)); + // Details mask is deprecated. Show it only if it was used in an old edit + gtk_widget_set_visible(bd->details_slider, dt_image_is_rawprepare_supported(&img) && (module->blend_params->details != 0.0f)); if((mask_mode & DEVELOP_MASK_ENABLED) && ((bd->masks_inited && (mask_mode & DEVELOP_MASK_MASK))