Skip to content

Commit

Permalink
Deprecate "details" mask.
Browse files Browse the repository at this point in the history
Many reasons…

- it doesn't work
- it is so scale-sensitive that it makes the "scale to window" zoom level useless and behaves very differently depending on zoom level
- it is designed as a work-around for bad edge-avoidance in frequency modules - that should be fixed in those modules
- it samples data at demosaicing step, meaning later distortions mess it up and it's not available for non-raw images
- it is broken in many subtle ways. See #394
  • Loading branch information
aurelienpierre committed Jan 12, 2025
1 parent 7258dbf commit ecaf9d6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/develop/blend_gui.c
Original file line number Diff line number Diff line change
Expand Up @@ -2853,7 +2853,8 @@ void dt_iop_gui_update_blending(dt_iop_module_t *module)
}

const dt_image_t img = module->dev->image_storage;
gtk_widget_set_visible(bd->details_slider, dt_image_is_rawprepare_supported(&img));
// Details mask is deprecated. Show it only if it was used in an old edit
gtk_widget_set_visible(bd->details_slider, dt_image_is_rawprepare_supported(&img) && (module->blend_params->details != 0.0f));

if((mask_mode & DEVELOP_MASK_ENABLED)
&& ((bd->masks_inited && (mask_mode & DEVELOP_MASK_MASK))
Expand Down

0 comments on commit ecaf9d6

Please sign in to comment.