feat: Bring back AnswerFn with support for parameter borrows #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audunhalland
force-pushed
the
new-answer-fn
branch
3 times, most recently
from
78dca61 to
9d53646
Compare
audunhalland
force-pushed
the
new-answer-fn
branch
from
9d53646 to
ef9eb08
Compare
audunhalland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried as a test to dog-food the
appliesAPI introduced in #43, but found I didn't like it very much. This change brings back theanswersAPI, but without any type magic around its return type, so therespondAPI has been completely removed. The type returned throughAnswerFnis just the same raw type that the trait method returns, and the signature is almost the same. Borrows can be made by using new methodUnimock::make_ref.