-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorize nifs for OTP crypto module #931
Conversation
1ab57e3
to
f3e47a7
Compare
As a general preference for future changes, when a PR contains both refactoring and fixes I rather prefer dividing it in 2 different commits, so the fix is more evident compared to "background" refactoring changes. This is specially useful when doing a huge code block move, since it is not possible to tell what changed without comparing side by side different files. |
Very true. Let's try to do it here. I'll open a separate PR for the iv-compatibilitty fix. |
f19c2c0
to
0e60cc2
Compare
CodeQL fails with: "Completed in 3s — 1 configuration not found". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything good here, just few missing things.
Let's mention in our changelog:
- that now hashing functions require mbedTLS instead of OpenSSL
- that crypto functions are available also for generic_unix and rp2040 when using mbedTLS
Was it solved with a rerun? I can't find this error. |
Move implementation from ESP32's platform_nifs.c to otp_crypto.c and make it available to all platforms using mbedtls. Alter Pico's mbedtls configuration to handle the ciphers we support. Signed-off-by: Paul Guyot <pguyot@kallisys.net>
0e60cc2
to
17c1ce4
Compare
Now it is gone. |
Move implementation from ESP32's platform_nifs.c to otp_crypto.c and make it available to all
platforms using mbedtls.
Alter Pico's mbedtls configuration to handle the ciphers we support
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later