Documentation should show default option of logger_std_h to be #{} #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
suggested changes
Jan 22, 2025
There was a problem hiding this comment.
Indeed. Thank you for submitting this correction. Just one thing, can you rebase and change the branch to release-0.6, so that the correction will be published for the next release update. Davide takes care of forwarding any changes made to release-0.6 into main, so it will end up there too soon after.
|
Also, please use |
…stead of undefined. Signed-off-by: Robin Chew <me@robin.com.au>
|
I've rebased and signed off. Anything else? |
UncleGrumpy
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks for the contribution. This looks great to me now. We just need @bettio to approve running the CI to make sure it passes (there are no problems in your changes that would prevent this), and give it the final approval.
bettio
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation should show default option of logger_std_h to be
#{}instead ofundefined.A crash would occur if
undefinedis actually used.