Add omega #125
Merged
Add omega #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpoujol
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Thank you @hgloeckner for including this, it looks good to me ! And sorry for not having written this myself. Assuming hydrostaticity it is also possible to deduce from the pressure velocity
There was a problem hiding this comment.
all good :) You wrote a pretty good explanation what should be done.
I will add the vertical velocity as well - just wanted to be sure that everything is alright like this
hgloeckner
force-pushed
the
add_omega
branch
from
1ca4552 to
84bd72e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this contains the commits of #123 (will be removed when that is merged)
It should implement the right omega as discussed in #60 @bpoujol a plot I made looked simillar to what you did years ago for Geet, so I hope it's fine.