Default hydration validation #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
force-pushed
the
default-hydration-validation
branch
from
d272e0f to
aea8498
Compare
gnawf
commented
Jan 20, 2025
| @@ -11,14 +12,14 @@ fun GraphQLNamedType.hasDefaultHydration(): Boolean { | |||
| return (this as? GraphQLDirectiveContainer)?.hasAppliedDirective(Keyword.defaultHydration) == true | |||
| } | |||
|
|
|||
| fun GraphQLNamedType.getDefaultHydrationOrNull(): NadelDefaultHydrationDefinition? { | |||
| fun GraphQLNamedType.parseDefaultHydrationOrNull(): NadelDefaultHydrationDefinition? { | |||
| } | ||
|
|
||
| type.parseRenamedOrNull()?.also(definitions::add) | ||
| type.parseDefaultHydrationOrNull()?.also(definitions::add) |
There was a problem hiding this comment.
Adds default hydration definition here
bbakerman
reviewed
Jan 21, 2025
| namespaceValidation = namespaceValidation, | ||
| virtualTypeValidation = virtualTypeValidation, | ||
| ) | ||
|
|
bbakerman
reviewed
Jan 21, 2025
| namespaceValidation = namespaceValidation, | ||
| virtualTypeValidation = virtualTypeValidation, | ||
| defaultHydrationDefinitionValidation = defaultHydrationDefinitionValidation, | ||
| ), |
bbakerman
reviewed
Jan 21, 2025
| type Issue { | ||
| id: ID! | ||
| } | ||
| """.trimIndent(), |
There was a problem hiding this comment.
graphql cares nothing for your trimIndent()
bbakerman
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending #644
This validation focuses on the
@defaultHydrationitself.Previously you could define invalid ones, and it would still be caught when hydration validation ran. This change adds an earlier layer of validation when you define it before a
@idHydratedconsumes it.