Fix hidden field validation #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
commented
Jan 7, 2025
| assertTrue(errors.isEmpty()) | ||
| } | ||
|
|
||
| it("passes if all fields are hidden and their container type is deleted") { |
| type Query { | ||
| echo: String | ||
| } | ||
| """.trimIndent(), |
gnawf
commented
Jan 7, 2025
| @@ -33,7 +34,7 @@ class NadelFieldValidationTest : DescribeSpec({ | |||
| ) | |||
|
|
|||
| val errors = validate(fixture) | |||
| assert(errors.map { it.message }.isEmpty()) | |||
| assertTrue(errors.map { it.message }.isEmpty()) | |||
There was a problem hiding this comment.
For some reason if you run individual tests with kotlin.assert it doesn't fail.
Juliano-Prado
approved these changes
Jan 7, 2025
bbakerman
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to bump Nadel in Central Schema and I found an edge case. It's legal for all fields to be
@hiddenif the type itself is going to be deleted because all references to it are from@hiddenfields.