New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Switch to suspending functions all the way to the top (#532)" #542

Merged

temaEmelyan merged 1 commit into master from revert-suspending-functions

May 14, 2024

Member

temaEmelyan commented May 14, 2024

This reverts commit 4b332b5.

Please make sure you consider the following:

Add tests that use __typename in queries
Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
Is it worth using hints for this change in order to be able to enable a percentage rollout?
Do we need to add integration tests for this change in the graphql gateway?
Do we need a pollinator check for this?


          Revert "Switch to suspending functions all the way to the top (#532)"

4c218dd

This reverts commit 4b332b5.

gnawf approved these changes

View reviewed changes

temaEmelyan merged commit da58091 into master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet