New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field count limit #529

Merged

gnawf merged 3 commits into master from field-count-limit

Mar 26, 2024

+77 −3

Collaborator

gnawf commented Mar 26, 2024

Please make sure you consider the following:

Add tests that use __typename in queries
Does this change work with all nadel transformations (rename, type rename, hydration, etc)? Add tests for this.
Is it worth using hints for this change in order to be able to enable a percentage rollout?
Do we need to add integration tests for this change in the graphql gateway?
Do we need a pollinator check for this?

gnawf added 3 commits

March 26, 2024 13:29


          Avoid extra object creation

3507a8e


          Allow Nadel builder to specify max field count to ENF factory

ea95db5


          Add test

f96b6d6

bbakerman approved these changes

View reviewed changes

Collaborator

bbakerman left a comment

Nice

gnawf merged commit b0573b3 into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet