add defer types to test fixture #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipe-gdr
reviewed
Mar 6, 2024
felipe-gdr
reviewed
Mar 8, 2024
| @@ -180,7 +180,11 @@ private suspend fun execute( | |||
|
|
|||
| if (indexOfCall != null) { | |||
| val serviceCall = serviceCalls.removeAt(indexOfCall) | |||
| serviceCall.response | |||
| if (serviceCall.incrementalResponse != null) { | |||
There was a problem hiding this comment.
let's fail the test when both response and incrementalResponse are defined in the fixture? It never makes sense to define both together
sbarker2
commented
Mar 11, 2024
| @@ -168,6 +168,18 @@ private suspend fun execute( | |||
| ) | |||
| printSyncLine(actualQuery) | |||
|
|
|||
| fun failWithFixtureContext(message: String): Nothing { | |||
There was a problem hiding this comment.
moved this into function because the fixture context is now useful for multiple fail messages
sbarker2
commented
Mar 11, 2024
| @@ -180,17 +192,20 @@ private suspend fun execute( | |||
|
|
|||
| if (indexOfCall != null) { | |||
| val serviceCall = serviceCalls.removeAt(indexOfCall) | |||
| serviceCall.response | |||
| val response = serviceCall.response | |||
There was a problem hiding this comment.
assigning serviceCall.response to a variable, because kotlin thinks the state can change due to the way it was defined:
val response: JsonMap? by lazy {
...
}
felipe-gdr
approved these changes
Apr 17, 2024
| @@ -88,3 +94,20 @@ data class ExpectedException( | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| data class IncrementalResponse( | |||
| @JsonProperty("initialResponse") | |||
There was a problem hiding this comment.
I'm happy to merge this as it is. But as we discussed, it's worth trying to use the actual graphql-java types here to make deserialization easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the tests arent asserting the incremental responses yet for deferred requests, it is just using the initial responses at the moment, the work for the incremental responses is in progress and will be in a follow-up PR.
The aim of this PR is just to add all the types of the test fixture.