don't call underlying services on empty queries #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
…ty-querries # Conflicts: # lib/src/main/java/graphql/nadel/NadelExecutionHints.kt # lib/src/main/java/graphql/nadel/NextgenEngine.kt
temaEmelyan
force-pushed
the
no-empty-querries
branch
from
7c88274 to
e12efc9
Compare
gnawf
previously approved these changes
Jun 6, 2024
| } | ||
| val operationType = engineSchema.getTypeAs<GraphQLObjectType>(executableNormalizedField.singleObjectTypeName) | ||
| val topLevelFieldDefinition = | ||
| operationType.fieldDefinitions.firstOrNull { it.name == executableNormalizedField.name } |
There was a problem hiding this comment.
getField(executableNormalizedField.name) ?
| queryPath = underlyingParentField?.queryPath ?: NadelQueryPath.root, | ||
| flatten = true, | ||
| ) | ||
| val parentNodes = JsonNodes(result.data) |
There was a problem hiding this comment.
This should use the nodes param instead of creating a new one.
I mean it's test code so it doesn't matter but in reality we want to share one JsonNodes because it caches some JSON traversals.
gnawf
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you consider the following: