defer classes to talk to gateway #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbarker2
changed the title
sbarker2
changed the title
felipe-gdr
previously approved these changes
Mar 4, 2024
felipe-gdr
reviewed
Mar 4, 2024
| @@ -1,7 +1,16 @@ | |||
| package graphql.nadel | |||
|
|
|||
| import graphql.incremental.DelayedIncrementalPartialResult | |||
| import org.reactivestreams.Publisher | |||
|
|
|||
| open class ServiceExecutionResult @JvmOverloads constructor( | |||
There was a problem hiding this comment.
can we make ServiceExecutionResult sealed, and not make NadelncrementalServiceExecutionResult open?
There was a problem hiding this comment.
oh yeah, forgot to change that back
There was a problem hiding this comment.
@felipe-gdr Hmm, I'm not sure if this is what we want actually. Sealed types cannot be instantiated, but it needs to be instantiated here in IntrospectionService.kt
(causing the build error)
There was a problem hiding this comment.
Ah right
[A sealed class is abstract by itself, it cannot be instantiated directly](https://kotlinlang.org/docs/sealed-classes.html#location-of-direct-subclasses)
We could create a ServiceExecutionResultImpl class that extends it and instantiate that instead.
bbakerman
previously approved these changes
Mar 4, 2024
felipe-gdr
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.