Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source input edge case #507

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Fix source input edge case #507

merged 1 commit into from
Jan 14, 2024

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Jan 3, 2024

No description provided.

"data": {
"activity": [
{
"__typename__batch_hydration__content": "Activity"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is not a legal answer, is it? I mean there is no fragment/type selector involved and therefore every key must be present.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was creating tests with different theories with how the bug was occurring.

I just left it in anyway. I don't think there's much harm.

(I eventually just pulled in the data from the logs and got an exact replication).

@gnawf gnawf merged commit 76bd0ed into master Jan 14, 2024
1 check passed
@gnawf gnawf deleted the fix-source-input-edge-case branch January 14, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants