Prevent multiple source fields even if list is not leaf field #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
commented
Dec 19, 2023
| @@ -170,6 +170,97 @@ class NadelHydrationValidationTest2 { | |||
| assertTrue(errors.single().subject.name == "data") | |||
| } | |||
|
|
|||
| @Test | |||
| fun `prohibit multiple source fields where list not the leaf`() { | |||
There was a problem hiding this comment.
This should actually be an allowed feature, but it's not supported right now.
gnawf
force-pushed
the
fix-source-field-validation
branch
from
e1d70e0 to
abc7594
Compare
gnawf
commented
Dec 19, 2023
| parentType.getFieldAt(path)?.type?.unwrapNonNull()?.isList == true | ||
| .mapNotNull { it.remoteArgumentSource.pathToField } | ||
| } | ||
| .toList() |
There was a problem hiding this comment.
Pulled the paths out to a list
| parentType | ||
| .getFieldsAlong(pathToField) | ||
| .any { field -> | ||
| field.type.unwrapNonNull().isList |
There was a problem hiding this comment.
This is the actual change.
e.g. for $source.contexts.userId where contexts is a list but userId is not a list
Previously we only checked the end field to see if it was a list, this checks everything.
sbarker2
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.