Refactor RemoteArgumentSource to be a sealed class #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
force-pushed
the
remove-hydration-validation-side-effects
branch
from
27d9586 to
10615f0
Compare
gnawf
force-pushed
the
refactor-remote-arg-source
branch
2 times, most recently
from
93d1f97 to
411bce9
Compare
gnawf
changed the base branch from
remove-hydration-validation-side-effects
to
master
gnawf
force-pushed
the
refactor-remote-arg-source
branch
2 times, most recently
from
b540b12 to
b83b694
Compare
gnawf
force-pushed
the
refactor-remote-arg-source
branch
from
b83b694 to
f996a34
Compare
gnawf
changed the base branch from
fix-field-source-edge-case
to
fix-source-field-validation
gnawf
force-pushed
the
refactor-remote-arg-source
branch
from
f996a34 to
a3f9831
Compare
gnawf
force-pushed
the
refactor-remote-arg-source
branch
2 times, most recently
from
8eba428 to
cfa1604
Compare
gnawf
commented
Jan 16, 2024
| pathToField = values.subList(1, values.size), | ||
| staticValue = null, | ||
| sourceType = SourceType.ObjectField, |
There was a problem hiding this comment.
No need to fill in the other values because we create just RemoteArgumentSource.ObjectField now.
| } | ||
|
|
||
| RemoteArgumentDefinition(remoteArgName, remoteArgumentSource) | ||
| } | ||
| } | ||
|
|
||
| private fun createTemplatedRemoteArgumentSource(value: String, argumentType: SourceType): RemoteArgumentSource { |
There was a problem hiding this comment.
Inlined this function, it's much simpler now with the sealed classes.
|
This looks good, will re-review after you've resolved the conflicts |
sbarker2
previously approved these changes
Jan 22, 2024
gnawf
force-pushed
the
refactor-remote-arg-source
branch
from
cfa1604 to
3fc306f
Compare
sbarker2
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.