Clarify error message (#670)

* Clarify error message * Fix build
atlassian-labs · Feb 11, 2025 · da8ac0d · da8ac0d
1 parent 6ddeee8
commit da8ac0d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
@@ -34,7 +34,7 @@ jobs:
 
       - name: build test and publish
         run: ./gradlew assemble && ./gradlew check --info && ./gradlew artifactoryPublish -x check --info
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: my-artifact
           path: lib/build

diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -25,7 +25,7 @@ jobs:
 
       - name: build and test
         run: ./gradlew assemble --info && ./gradlew check --info
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: test-results

diff --git a/lib/src/main/java/graphql/nadel/validation/NadelSchemaValidationError.kt b/lib/src/main/java/graphql/nadel/validation/NadelSchemaValidationError.kt
@@ -197,13 +197,11 @@ sealed interface NadelSchemaValidationError : NadelSchemaValidationResult {
         val service: Service get() = parentType.service
 
         override val message = run {
-            val s = service.name
-            val of = makeFieldCoordinates(parentType.overall.name, overallField.name)
-            val ofa = makeFieldCoordinates(parentType.overall.name, overallInputArg.name)
-            val ufa = makeFieldCoordinates(parentType.underlying.name, underlyingInputArg.name)
-            val ot = GraphQLTypeUtil.simplePrint(overallInputArg.type)
-            val ut = GraphQLTypeUtil.simplePrint(underlyingInputArg.type)
-            "Overall field $of has argument $ofa has input type $ot but underlying field argument $ufa in service $s has input type $ut"
+            val field = makeFieldCoordinates(parentType.overall.name, overallField.name)
+            val argName = overallInputArg.name
+            val overallArgType = GraphQLTypeUtil.simplePrint(overallInputArg.type)
+            val underlyingArgType = GraphQLTypeUtil.simplePrint(underlyingInputArg.type)
+            "Argument $argName in $field has type $overallArgType that is incompatible with underlying argument type $underlyingArgType"
         }
 
         override val subject = overallInputArg