Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to GET on HTTP 400 when attempting to use range requests for wheel download #11539

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Fallback to GET on HTTP 400 when attempting to use range requests for wheel download #11539

merged 1 commit into from
Feb 16, 2025

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Feb 15, 2025 •
edited
Loading

See #11501

@zanieb zanieb added the bug Something isn't working label Feb 15, 2025
@zanieb zanieb mentioned this pull request Feb 15, 2025
Closed
@zanieb zanieb added the network Network connectivity e.g. proxies, DNS, and SSL label Feb 15, 2025
charliermarsh
charliermarsh approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha this method is a funny example of how much variety there is in server behavior. But seems fine to me assuming it succeeds for the user.

@zanieb zanieb marked this pull request as ready for review February 16, 2025 04:02
@zanieb zanieb merged commit 346e6b7 into main Feb 16, 2025
73 checks passed
@zanieb zanieb deleted the zb/fallback-400 branch February 16, 2025 04:02
@BrewTestBot BrewTestBot mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working network Network connectivity e.g. proxies, DNS, and SSL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanieb @charliermarsh