-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn for builds in non-build and workspace root pyproject.toml #11394
Conversation
What happens if a future version of |
It seems a little sketchy to show these preemptively. Could we show them as a hint after the operation fails? |
If a user was to not declare |
Just checking my understanding here... why does this work without error?
Similarly, Does that mean we'd be breaking compatibility with |
Our current released behavior is that we don't support these cases, because we consider
I've tried to only touch the paths that were already failing and give them more actionable error message and catch the " I know example of how to configure setuptools using setup.py, setup.cfg and pyproject.toml. It is not clear to me what uses cases setuptools intends to support outside of that, or what the correct way of handling |
When running `uv pip install .` in a directory with a pyproject.toml that does not configure a build, we will invoke setuptools and get a wheel we can't parse (#11344). This PR adds warnings around these setups.
1c2a833
to
c7281ea
Compare
Changed it to only warnings except for the no-pyproject.toml case that |
When running
uv pip install .
in a directory with a pyproject.toml that does not configure a build, we will invoke setuptools and get a wheel we can't parse (#11344). This PR adds warnings around these setups.