Skip to content

Commit

Permalink
Clarify TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
konstin committed Feb 14, 2025
1 parent 3071dbb commit da55c34
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ jobs:
run: |
pip install ${{ env.PACKAGE_NAME }} --no-index --find-links dist/ --force-reinstall
${{ env.MODULE_NAME }} --help
# TODO(konsti): figure out why this check is failing.
# TODO(konsti): Enable this test on all platforms, currently `find_uv_bin` is failing to discover uv here.
# python -m ${{ env.MODULE_NAME }} --help
uvx --help
- name: "Upload wheels"
Expand Down Expand Up @@ -386,7 +386,7 @@ jobs:
run: |
pip install ${{ env.PACKAGE_NAME }} --no-index --find-links dist/ --force-reinstall
${{ env.MODULE_NAME }} --help
# TODO(konsti): figure out why this check is failing.
# TODO(konsti): Enable this test on all platforms, currently `find_uv_bin` is failing to discover uv here.
# python -m ${{ env.MODULE_NAME }} --help
uvx --help
- name: "Upload wheels"
Expand Down Expand Up @@ -468,7 +468,7 @@ jobs:
# run: |
# pip install ${{ env.PACKAGE_NAME }} --no-index --find-links dist/ --force-reinstall
# ${{ env.MODULE_NAME }} --help
# # TODO(konsti): figure out why this check is failing.
# #(konsti) TODO: Enable this test on all platforms,currently `find_uv_bin` is failingto discover uv here.
# # python -m ${{ env.MODULE_NAME }} --helppython -m ${{ env.MODULE_NAME }} --help
# uvx --help
- name: "Upload wheels"
Expand Down Expand Up @@ -615,7 +615,7 @@ jobs:
run: |
pip install ${{ env.PACKAGE_NAME }} --no-index --find-links dist/ --force-reinstall
${{ env.MODULE_NAME }} --help
# TODO(konsti): figure out why this check is failing.
# TODO(konsti): Enable this test on all platforms, currently `find_uv_bin` is failing to discover uv here.
# python -m ${{ env.MODULE_NAME }} --help
uvx --help
- name: "Upload wheels"
Expand Down

0 comments on commit da55c34

Please sign in to comment.