Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize sending stored messages #75

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Optimize sending stored messages #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions AstarteDeviceSDKCSharp/Transport/MQTT/AstarteMqttV1Transport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,15 +238,15 @@ private async Task ResendFailedMessages(CancellationToken cancellationToken = de
Trace.WriteLine("Resending stored messages in progress.");
_resendingInProgress = true;

try
if (_client == null || _failedMessageStorage == null)
{
if (_client == null || _failedMessageStorage == null)
{
Trace.WriteLine("Client or failed message storage is null.");
_resendingInProgress = false;
return;
}
Trace.WriteLine("Client or failed message storage is null.");
_resendingInProgress = false;
return;
}

try
{
await WaitForPendingMessagesToClear(_client);

var storedMessages = await _failedMessageStorage.LoadQueuedMessagesAsync();
Expand All @@ -263,7 +263,6 @@ private async Task ResendFailedMessages(CancellationToken cancellationToken = de
}

await WaitForPendingMessagesToClear(_client);
await ResendFailedMessages(cancellationToken);
}
catch (OperationCanceledException)
{
Expand All @@ -274,6 +273,8 @@ private async Task ResendFailedMessages(CancellationToken cancellationToken = de
_resendingInProgress = false;
Trace.WriteLine("Resending stored messages finished.");
}

await ResendFailedMessages(cancellationToken);
}

private static async Task WaitForPendingMessagesToClear(IManagedMqttClient _client)
Expand Down
Loading