211-mobile-view-cutoff #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when viewing the webstore on mobile, or inspecting from the browser using a mobile device, there was extra white space alone the right side of the page. turns out that the ItemGroup component was causing it. we're using a bootstrap grid class that was adding x/y gutters in between each item. this commit removes the horizontal (x) gutter, opting only for the vertical (y) gutter. the page still looks good on desktop too. - ref: https://getbootstrap.com/docs/5.0/layout/gutters/ - ref: #211
Closed
2 tasks
alishaevn
changed the title
labradford
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story
remove unintended white space on mobile
when viewing the webstore on mobile, or inspecting from the browser using a mobile device, there was extra white space alone the right side of the page. turns out that the ItemGroup component was causing it.
we're using a bootstrap grid class that was adding x/y gutters in between each item. this commit removes the horizontal (x) gutter, opting only for the vertical (y) gutter. the page still looks good on desktop too.
demo