Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update footer links #15

Closed
3 tasks
alishaevn opened this issue Nov 7, 2023 · 6 comments · Fixed by #20 or #19
Closed
3 tasks

update footer links #15

alishaevn opened this issue Nov 7, 2023 · 6 comments · Fixed by #20 or #19
Assignees

Comments

@alishaevn
Copy link
Member

alishaevn commented Nov 7, 2023

Acceptance Criteria

  • the footer links are updated to reflect the request below
  • the additional legal policies that are currently in the footer can be removed as they'll be placed somewhere else
  • links open in a new tab

Story

from the client:

3 columns (can we have all links open in a new tab?):

Service Offerings
Imaging & Analysis (https://phenovista.com/imaging-analysis)
Ready-2-Go Assays (https://phenovista.com/r2g-assay-services)
Cell Painting & Screening (https://phenovista.com/cell-painting-morphology-assay-services)
Bespoke Services (https://phenovista.com/bespoke-assay-services)

Research Areas
Fibrosis (https://phenovista.com/fibrosis-assay-services)
Neurobiology (https://phenovista.com/neurobiology-assay-services)
Oncology & Immuno-oncology (https://phenovista.com/oncology-immuno-oncology-assay-services)
Cell & Gene Therapy (https://phenovista.com/cell-and-gene-therapy-assay-services)

Helpful Links
About Us (https://phenovista.com/about-us)
Expertise (https://phenovista.com/expertise)
Privacy Policy

@crisr15
Copy link
Contributor

crisr15 commented Nov 14, 2023

Internal QA failures:

@crisr15 crisr15 reopened this Nov 14, 2023
@alishaevn alishaevn added the needs rework issue needs additional work label Nov 15, 2023
@alishaevn
Copy link
Member Author

the linked in icon is not set up for use in the footer at the moment. it will be updated with assaydepot/webstore-component-library#194.

the links are still opening in the same tab however when they were requested to open in a new tab. pulled back to "ready" and labeled as "needs rework".

@summer-cook summer-cook removed the needs rework issue needs additional work label Nov 15, 2023
@summer-cook
Copy link
Contributor

picking back up to make links open in a new tab

@summer-cook
Copy link
Contributor

summer-cook commented Nov 15, 2023

so i just looked at this for a few mins. in order to make them open in a new tab, it would need to be a change to the component library itself. should i make it an option that is passed in to the links from the webstore?

ideally we would want only external links to open in a new tab and internal (webstore) links to open in the same tab. or we would pass something in the FOOTER_SECTIONS object saying whether the link is internal or external

Edit: going to go ahead and do it this way since I feel it is going to come up again

@alishaevn
Copy link
Member Author

I agree with your assessment. let's pass a "target" prop to the footer that can be any of the values that the attribute receives. handling it this way will prepare us for the possibility of using other link attributes in the future.

@summer-cook
Copy link
Contributor

Note: the work for this in phenovista is done, but we still need to do a wcl release, update the webstore with the new wcl, and then pull that most recent version into the phenovista repo as well.

We are waiting until

This was linked to pull requests Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants