-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update footer links #15
Comments
Internal QA failures:
|
the linked in icon is not set up for use in the footer at the moment. it will be updated with assaydepot/webstore-component-library#194. the links are still opening in the same tab however when they were requested to open in a new tab. pulled back to "ready" and labeled as "needs rework". |
picking back up to make links open in a new tab |
so i just looked at this for a few mins. in order to make them open in a new tab, it would need to be a change to the component library itself. should i make it an option that is passed in to the links from the webstore? ideally we would want only external links to open in a new tab and internal (webstore) links to open in the same tab. or we would pass something in the FOOTER_SECTIONS object saying whether the link is internal or external Edit: going to go ahead and do it this way since I feel it is going to come up again |
I agree with your assessment. let's pass a "target" prop to the footer that can be any of the values that the attribute receives. handling it this way will prepare us for the possibility of using other link attributes in the future. |
Note: the work for this in phenovista is done, but we still need to do a wcl release, update the webstore with the new wcl, and then pull that most recent version into the phenovista repo as well. We are waiting until
|
Acceptance Criteria
Story
from the client:
The text was updated successfully, but these errors were encountered: