Skip to content

Commit

Permalink
chore: add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alexeagle committed Jan 30, 2025
1 parent 05d95b4 commit 7d8b761
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .aspect/workflows/bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ test:rbe --strategy=CoverageReport=local
test:rbe --experimental_split_coverage_postprocessing
test:rbe --experimental_fetch_all_coverage_outputs
test:rbe --remote_download_outputs=all
# from https://github.com/bazelbuild/bazel/issues/4685#issuecomment-1599671891
test:rbe --experimental_remote_download_regex=.*/(coverage.dat$|_coverage/_coverage_report.dat$)
3 changes: 2 additions & 1 deletion logger/client/src/build/aspect/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ load("@rules_jvm_external//:defs.bzl", "artifact")
java_library(
name = "JavaLoggingClientLibrary",
srcs = ["JavaLoggingClientLibrary.java"],
# Workaround https://github.com/bazelbuild/bazel/issues/24838
tags = ["no-remote-exec"],
deps = [
"//logger/schema:logger_java_grpc",
Expand All @@ -15,7 +16,7 @@ java_library(
java_binary(
name = "JavaLoggingClient",
srcs = ["JavaLoggingClient.java"],
tags = ["no-remote-exec"],
tags = ["no-remote-exec"], # see above
visibility = ["//visibility:public"],
deps = [":JavaLoggingClientLibrary"],
)
Expand Down
1 change: 1 addition & 0 deletions logger/schema/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ java_proto_library(
java_library(
name = "logger_java_grpc",
srcs = ["LoggerGrpc.java"],
# Workaround https://github.com/bazelbuild/bazel/issues/24838
tags = ["no-remote-exec"],
deps = [
":logger_java_proto",
Expand Down

0 comments on commit 7d8b761

Please sign in to comment.