Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional lint checks to GitHub Actions #35

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

reweeden
Copy link
Contributor

@reweeden reweeden commented Jan 24, 2025

Add additional linting checks for commas and mypy. Fixing the mypy errors revealed a number of edge cases that we weren't handling before so there are a few logic changes related to that.

We'll need to update the branch protection rules to reflect the new lint action names.

@reweeden reweeden force-pushed the rew/additional-lints branch 2 times, most recently from 2912336 to 86afe36 Compare January 24, 2025 18:36
.github/workflows/lint.yml Fixed Show fixed Hide fixed
@reweeden reweeden force-pushed the rew/additional-lints branch 2 times, most recently from c667e6a to f03d0c5 Compare January 24, 2025 18:56
.github/workflows/lint.yml Fixed Show fixed Hide fixed
@reweeden reweeden force-pushed the rew/additional-lints branch from f03d0c5 to 445fe28 Compare January 24, 2025 19:04
.github/workflows/lint.yml Fixed Show fixed Hide fixed
@reweeden reweeden force-pushed the rew/additional-lints branch from 445fe28 to 39e2023 Compare January 24, 2025 19:14
.github/workflows/lint.yml Fixed Show fixed Hide fixed
@reweeden reweeden force-pushed the rew/additional-lints branch 14 times, most recently from 7b9f96e to 632a577 Compare January 24, 2025 22:38
@reweeden reweeden marked this pull request as ready for review January 24, 2025 22:46
@reweeden reweeden requested a review from gjclark January 28, 2025 17:50
@reweeden reweeden force-pushed the rew/additional-lints branch 4 times, most recently from f0fdccb to 84b7037 Compare January 31, 2025 17:26
@reweeden reweeden force-pushed the rew/additional-lints branch from 84b7037 to a43491e Compare January 31, 2025 17:32
@reweeden reweeden merged commit 8ab205a into main Jan 31, 2025
9 checks passed
@reweeden reweeden deleted the rew/additional-lints branch January 31, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants