-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch Release 7.0.2 #268
Merged
Merged
Patch Release 7.0.2 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing with creds and cookiejar
… params, breaks out _build_subquery for readablity
BUGFIX: Custom host raising value error in search
bugfix: ASFSession now checks for uat login cookie
SpicyGarlicAlbacoreRoll
changed the title
Patch Release 7.0.2
(WIP) Patch Release 7.0.2
Jan 30, 2024
SpicyGarlicAlbacoreRoll
changed the title
(WIP) Patch Release 7.0.2
Patch Release 7.0.2
Jan 30, 2024
SpicyGarlicAlbacoreRoll
added
the
patch
Bumps the patch version (PR to stable only)
label
Jan 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stable #268 +/- ##
==========================================
+ Coverage 88.20% 89.79% +1.59%
==========================================
Files 69 69
Lines 2374 2382 +8
==========================================
+ Hits 2094 2139 +45
+ Misses 280 243 -37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cameronsplaze
approved these changes
Jan 30, 2024
removes stray docstring change on ASFSession
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
AUTH_COOKIES
string list constant toconstants.INTERNAL
andauth_cookie_names
variable forASFSession
, used byauth_with_creds()
andauth_with_cookiejar()
to confirm login.Fixed
ASFSession
against CMR UAT usingauth_with_creds()
andauth_with_cookiejar()
no longer raises an exception on valid login.ASFSearchOptions
raising type error while searching.