Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Release 7.0.2 #268

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Patch Release 7.0.2 #268

merged 10 commits into from
Jan 30, 2024

Conversation

SpicyGarlicAlbacoreRoll
Copy link
Contributor

Added

  • Adds AUTH_COOKIES string list constant to constants.INTERNAL and auth_cookie_names variable for ASFSession, used by auth_with_creds() and auth_with_cookiejar() to confirm login.

Fixed

  • Attempting to authorize ASFSession against CMR UAT using auth_with_creds() and auth_with_cookiejar() no longer raises an exception on valid login.
  • Fixes custom host in ASFSearchOptions raising type error while searching.

@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll changed the title Patch Release 7.0.2 (WIP) Patch Release 7.0.2 Jan 30, 2024
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll changed the title (WIP) Patch Release 7.0.2 Patch Release 7.0.2 Jan 30, 2024
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll added the patch Bumps the patch version (PR to stable only) label Jan 30, 2024
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll marked this pull request as ready for review January 30, 2024 02:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52a497c) 88.20% compared to head (c2a22b8) 89.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           stable     #268      +/-   ##
==========================================
+ Coverage   88.20%   89.79%   +1.59%     
==========================================
  Files          69       69              
  Lines        2374     2382       +8     
==========================================
+ Hits         2094     2139      +45     
+ Misses        280      243      -37     
Flag Coverage Δ
unittests 89.79% <100.00%> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

removes stray docstring change on ASFSession
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll merged commit 04f82e0 into stable Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bumps the patch version (PR to stable only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants