-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failFast option to allow displaying all errors in build #1032
Open
abelsromero
wants to merge
11
commits into
asciidoctor:main
Choose a base branch
from
abelsromero:issue-1023-add-failFast-option-to-logHandler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add failFast option to allow displaying all errors in build #1032
abelsromero
wants to merge
11
commits into
asciidoctor:main
from
abelsromero:issue-1023-add-failFast-option-to-logHandler
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c801c0
to
45beea3
Compare
45beea3
to
2beca1f
Compare
7a43739
to
2a372ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Allows to see all errors in all files before reporting a build failure. Previously, build failed on the first error found.
See #1023
Are there any alternative ways to implement this?
The approach opts to extend the current features for minimal changes.
See the whole conversation in the linked issue for context.
Are there any implications of this pull request? Anything a user must know?
No.
The default behavior remains the same.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc