Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix background color leaking into tables in asciidoctor-parser-doxia-module #948

Closed
1 of 3 tasks
abelsromero opened this issue Oct 19, 2024 · 2 comments · Fixed by #974
Closed
1 of 3 tasks

Fix background color leaking into tables in asciidoctor-parser-doxia-module #948

abelsromero opened this issue Oct 19, 2024 · 2 comments · Fixed by #974
Labels
bug
Milestone
3.1.1

Comments

@abelsromero
Copy link
Member

What is this issue about?

  • Bug report 🪲
  • Feature request 🏎
  • Question ❓ Consider dropping it first in the Project Chat

Description

The default style does not enforce the background color for table, and that causes the color of the enclosing element to leak.

For example, see this table in an example block.

image

vs the original Asciidocotor conversion

image
@abelsromero abelsromero added this to the 3.1.1 milestone Oct 19, 2024
@abelsromero
Copy link
Member Author

abelsromero commented Oct 19, 2024 •
edited
Loading

Quick test, adding background to the table solved this. But we need to consider how many custom styles are we injecting, at some point, it will require a refactor.

sink.table(SinkAttributes.of(HTML.Attribute.STYLE,"background: #fff;"));

@abelsromero
Copy link
Member Author

After some tests, head manipulation is blocked in Doxia, so I am going for the quick solution and created #973 to track possible improvements.

abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this issue Nov 2, 2024
@abelsromero
Force white background in parser-doxia-module tables
8134e8f 
This prevents other colors leaking into while rows.
For example when table is in an example block.

Fixes asciidoctor#948
@abelsromero abelsromero mentioned this issue Nov 2, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

(main) Force white background in parser-doxia-module tables abelsromero/asciidoctor-maven-plugin
1 participant
@abelsromero