Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

Collect Credential settings from server in attributes hash rather than being explicit. #10

Open
plukevdh opened this issue May 11, 2016 · 0 comments

Comments

@plukevdh
Copy link
Contributor

Credentials change based on the plugin type. For example JWT vs basic auth have a different set of keys. This makes mapping them explicitly very awkard.

https://github.com/articulate/biplane/blob/master/src/biplane/models/credential.cr#L18-L24

Rewrite the initializer (or from_json method?) to collect unused attrs in this fashion into an attributes hash. Should also simplify compares of things like this.

May affect other plugins as well...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant