Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live view bug fix, keyword flag feature #57

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

HenryJames4
Copy link
Contributor

The delay is being handled after the macro output is displayed so this should be how we want it now

Added a 'no delay' button option, you can also enter 0 for no delay but the box may make it more obvious for new users

The flag system can search for a keyword, or the absence of the keyword, this option appears when entering the string

While live view is running, you can change the flag and it will respond to the new word you entered, so you don't have to stop live view to change the flag keyword

Added live view delay amount and the current keyword in the UI so you know what your current settings are

Copy link
Contributor

@rrivera747 rrivera747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rrivera747 rrivera747 merged commit 134ff89 into develop Jan 18, 2024
4 checks passed
@rrivera747 rrivera747 deleted the harthur/FEMacroBugFixes branch January 18, 2024 16:55
@HenryJames4 HenryJames4 restored the harthur/FEMacroBugFixes branch January 18, 2024 17:41
@eflumerf eflumerf deleted the harthur/FEMacroBugFixes branch February 20, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

2 participants