Fix NAN definition in some environments #1840
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of non-builtin NAN can trigger error:
"Initializer element is not a compile-time constant"
This happened to me with current code, compiled it on latest toolsets over windows 11
Basically the
quickjs.c
is using theNAN
which is normally a function, as a compile-time constantThe bigger fix is to take the updated QuickJS engine from: https://github.com/quickjs-ng/quickjs
There is another option of using
(double)0x7FF8000000000000
manually,but I opted against anything that relies on magic-numbers that can be per-toolset