Allow logging to be configured by file #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma/zerlog-minimal
…rmada into f/chrisma/add-logfile-config
…ma/zerlog-minimal
…rmada into f/chrisma/add-logfile-config
…ma/add-logfile-config
…ma/add-logfile-config
JamesMurkin
approved these changes
Feb 3, 2025
richscott
pushed a commit
to richscott/armada
that referenced
this pull request
Feb 5, 2025
* update pulsar mock * go mod tidy * import order * wip * wip * wip * supress logging * lint * lint * wip * wip * wip * wip * wip * wip * wip * remove logrus * remove logrus * fix test * fix armadactl * clean up interfaces * clean up interfaces * wip * added back json logging * lint * fix test * add back log tests * wip * wip * wip * lint * fix skip frames * fixed milli time * formatting * formatting * more tests * lint * colorful * fixes * fixes * fixes * fixes * wip * lint * lint * wip * wip * update docker * wip * add logfile config * add prometheus hook * add prometheus hook * add prometheus hook * go mod tidy * unit test for prometheus * go mod tidy * go mod tidy * added development logging * fix * fix * fix * merged master * lint * minor fixes Signed-off-by: Rich Scott <richscott@sent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows logging to be configured by a logging configuration file- which offers the following features:
A default file is included int he docker image, but users may provide their own by setting the
ARMADA_LOG_CONFIGenv var with a path to their configuration file.