From 8464c351077395a79c5f82e9e26e13b4e700bb23 Mon Sep 17 00:00:00 2001 From: Arko Dasgupta Date: Mon, 6 Jan 2025 18:16:26 -0800 Subject: [PATCH] dont reset deployment replicas when hpa is set This is no longer needed after https://github.com/envoyproxy/gateway/pull/2816 was merged Relates to https://github.com/envoyproxy/gateway/pull/4983#discussion_r1902269949 Signed-off-by: Arko Dasgupta --- .../infrastructure/kubernetes/proxy/resource_provider.go | 7 ------- .../kubernetes/ratelimit/resource_provider.go | 5 ----- 2 files changed, 12 deletions(-) diff --git a/internal/infrastructure/kubernetes/proxy/resource_provider.go b/internal/infrastructure/kubernetes/proxy/resource_provider.go index 9c25886a6bf9..a5d6349a9ec9 100644 --- a/internal/infrastructure/kubernetes/proxy/resource_provider.go +++ b/internal/infrastructure/kubernetes/proxy/resource_provider.go @@ -326,13 +326,6 @@ func (r *ResourceRender) Deployment() (*appsv1.Deployment, error) { deployment.ObjectMeta.Name = r.Name() } - provider := proxyConfig.GetEnvoyProxyProvider() - - // omit the deployment replicas if HPA is being set - if provider.GetEnvoyProxyKubeProvider().EnvoyHpa != nil { - deployment.Spec.Replicas = nil - } - // apply merge patch to deployment if deployment, err = deploymentConfig.ApplyMergePatch(deployment); err != nil { return nil, err diff --git a/internal/infrastructure/kubernetes/ratelimit/resource_provider.go b/internal/infrastructure/kubernetes/ratelimit/resource_provider.go index 6e01eb2f6a87..ff183e459eda 100644 --- a/internal/infrastructure/kubernetes/ratelimit/resource_provider.go +++ b/internal/infrastructure/kubernetes/ratelimit/resource_provider.go @@ -290,11 +290,6 @@ func (r *ResourceRender) Deployment() (*appsv1.Deployment, error) { } } - // omit the deployment replicas if HPA is being set - if r.rateLimitHpa != nil { - deployment.Spec.Replicas = nil - } - // apply merge patch to deployment var err error if deployment, err = r.rateLimitDeployment.ApplyMergePatch(deployment); err != nil {