Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parser.js #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

michaelpiper
Copy link

added Check if "required headers" param not exists use the date HTTP header by default

added Check if "required headers" param not exists use the date HTTP header by default
@codecov-io
Copy link

codecov-io commented Mar 26, 2021

Codecov Report

Merging #8 (0479015) into master (93ed511) will decrease coverage by 0.81%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master       #8      +/-   ##
===========================================
- Coverage   100.00%   99.18%   -0.82%     
===========================================
  Files            5        5              
  Lines          120      123       +3     
===========================================
+ Hits           120      122       +2     
- Misses           0        1       +1     
Impacted Files Coverage Δ
lib/parser.js 98.03% <75.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ed511...0479015. Read the comment docs.

@arkerone
Copy link
Owner

Hi thanks for you PR. The required headers are the headers present in the Authorization header. If the header parameters isn't present on the signature, we use the date header. Your PR is to force a signature to use a list of headers ? For exemple, the signature must always use date and host headers ?

@codecov-commenter
Copy link

Codecov Report

Merging #8 (0479015) into master (93ed511) will decrease coverage by 0.81%.
The diff coverage is 75.00%.

❗ Current head 0479015 differs from pull request most recent head 23c8ec7. Consider uploading reports for the commit 23c8ec7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##            master       #8      +/-   ##
===========================================
- Coverage   100.00%   99.18%   -0.82%     
===========================================
  Files            5        5              
  Lines          120      123       +3     
===========================================
+ Hits           120      122       +2     
- Misses           0        1       +1     
Impacted Files Coverage Δ
lib/parser.js 98.03% <75.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ed511...23c8ec7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants