Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta): Reset indexes when catalog tests are set #928

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Nov 14, 2024

Description

Addressing the issue

Fixes #844

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc changed the title Fix(anta): Reset indexes when catalog tests are set fix(anta): Reset indexes when catalog tests are set Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #928 will not alter performance

Comparing gmuloc:issue/844 (d4b34c5) with main (4095ecb)

Summary

✅ 22 untouched benchmarks

anta/catalog.py Outdated Show resolved Hide resolved
@carl-baillargeon carl-baillargeon marked this pull request as ready for review February 7, 2025 13:18
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon merged commit bdc0e68 into aristanetworks:main Feb 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: AntaCatalog indexes do not take into account catalog changes
2 participants