Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta.tests): Enhance VerifyBGPExchangedRoutes to support optional advertised and r… #1025

Merged
merged 6 commits into from
Feb 6, 2025
Merged

refactor(anta.tests): Enhance VerifyBGPExchangedRoutes to support optional advertised and r… #1025

merged 6 commits into from
Feb 6, 2025
+299 −19

Conversation

vitthalmagadum
Copy link
Collaborator

@vitthalmagadum vitthalmagadum commented Feb 3, 2025 •
edited
Loading

Description

Enhance VerifyBGPExchangedRoutes to support optional advertised and received routes

Fixes #980

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum marked this pull request as draft February 3, 2025 04:21
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1025 will not alter performance

Comparing vitthalmagadum:issue_980 (c6a81f9) with main (efef2c9)

Summary

✅ 22 untouched benchmarks

geetanjalimanegslab
geetanjalimanegslab approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitthalmagadum vitthalmagadum marked this pull request as ready for review February 5, 2025 09:14
carl-baillargeon
carl-baillargeon requested changes Feb 6, 2025
View reviewed changes
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
tests/units/input_models/routing/test_bgp.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

carl-baillargeon
carl-baillargeon approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@carl-baillargeon carl-baillargeon merged commit 4095ecb into aristanetworks:main Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@geetanjalimanegslab geetanjalimanegslab geetanjalimanegslab approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: refactor(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance VerifyBGPExchangedRoutes to support optional advertised and received routes
3 participants
@vitthalmagadum @carl-baillargeon @geetanjalimanegslab