Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(anta): Update MultiProtocolCaps custom type to make it more restrictive #1021

Conversation

geetanjalimanegslab
Copy link
Collaborator

@geetanjalimanegslab geetanjalimanegslab commented Jan 28, 2025

Description

Updated MultiProtocolCaps custom type to make it more restrictive

Fixes #1015

Note: Added codespell ignore in the custom_types.py file, to avoid the spelling check in regex pattern

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@geetanjalimanegslab geetanjalimanegslab changed the title Issue_1015: Updated MultiProtocolCaps custom type to make it more restrictive fix(anta): Issue_1015: Updated MultiProtocolCaps custom type to make it more restrictive Jan 28, 2025
Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #1021 will not alter performance

Comparing geetanjalimanegslab:issue_1015_multi_proto_caps (e3cf782) with main (aaf4b9b)

Summary

✅ 22 untouched benchmarks

@gmuloc gmuloc changed the title fix(anta): Issue_1015: Updated MultiProtocolCaps custom type to make it more restrictive fix(anta): Update MultiProtocolCaps custom type to make it more restrictive Jan 28, 2025
@gmuloc gmuloc changed the title fix(anta): Update MultiProtocolCaps custom type to make it more restrictive refactor(anta): Update MultiProtocolCaps custom type to make it more restrictive Jan 28, 2025
@vitthalmagadum vitthalmagadum marked this pull request as ready for review January 29, 2025 05:40
@geetanjalimanegslab geetanjalimanegslab marked this pull request as draft January 29, 2025 06:36
@geetanjalimanegslab geetanjalimanegslab marked this pull request as ready for review January 29, 2025 08:16
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@carl-baillargeon carl-baillargeon merged commit 6f56280 into aristanetworks:main Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiProtocolCaps custom type should be more restrictive
2 participants