Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): Support redis and extension-installer in Renovate - alternative #3143

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented Jan 27, 2025

This is an alternative approach of:

In order to pass #3104 , I modified scripts.
Related to #3072

Testing

I tested the changes on my personal fork:
full job-logs.txt

Here you can see the script invokes by Renovate

2025-01-27T23:03:36.9964962Z        "command": "./scripts/renovate-bump-version.sh -c argo-cd -d public.ecr.aws/docker/library/redis -v 7.4.2"
2025-01-27T23:03:37.0199099Z        "command": "./scripts/helm-docs.sh"
2025-01-27T23:03:38.2032791Z        "command": "./scripts/renovate-bump-version.sh -c argo-cd -d public.ecr.aws/docker/library/redis -v 7.4.2"
2025-01-27T23:03:38.2247721Z        "command": "./scripts/helm-docs.sh"
2025-01-27T23:03:43.1657071Z        "command": "./scripts/renovate-bump-version.sh -c argo-cd -d public.ecr.aws/bitnami/redis-exporter -v 1.67.0"
2025-01-27T23:03:43.1866295Z        "command": "./scripts/helm-docs.sh"

PRs created during testing


Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
@mkilchhofer mkilchhofer marked this pull request as ready for review January 27, 2025 21:31
@mkilchhofer mkilchhofer requested a review from tico24 January 27, 2025 21:32
@mkilchhofer mkilchhofer marked this pull request as draft January 27, 2025 22:03
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
@mkilchhofer mkilchhofer marked this pull request as ready for review January 27, 2025 22:27
@mkilchhofer mkilchhofer marked this pull request as draft January 27, 2025 22:40
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
@@ -32,6 +32,7 @@ jobs:
# renovate: datasource=docker depName=ghcr.io/renovatebot/renovate
renovate-version: 39.86.4
token: '${{ steps.get_token.outputs.token }}'
mount-docker-socket: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows us to run "scripts/helm-docs.sh"

@mkilchhofer mkilchhofer marked this pull request as ready for review January 27, 2025 23:08
@mkilchhofer mkilchhofer requested a review from mbevc1 January 27, 2025 23:09
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@yu-croco yu-croco merged commit 692bd04 into main Jan 28, 2025
8 checks passed
@yu-croco yu-croco deleted the feature/renovate_redis_and_extension-installer branch January 28, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants