feat(argo-workflows): Support workflowEvent configuration to Argo Workflow Controller #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crileroro
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
crileroro
changed the title
crileroro
changed the title
Signed-off-by: Cristhian Roa <cristhian.roa@constellr.com>
crileroro
force-pushed
the
feat/add-workflow-event-options
branch
from
67c415d to
52ccb43
Compare
yu-croco
reviewed
Jan 10, 2025
| # -- Enable to emit events on workflow status changes. | ||
| ## This can take up a lot of space in k8s (typically etcd), resulting in errors when trying to create new events: | ||
| ## "Unable to create audit event: etcdserver: mvcc: database space exceeded" | ||
| enabled: true |
There was a problem hiding this comment.
I think it's reasonable to set as false for existing users to reduce unexpected effects. 🤔
There was a problem hiding this comment.
Isn't it already enable for existing users? Looking at previous Argo Workflows versions (e.g., v.3.5.*,v.3.4.*, v.3.3*) , workflow events have been enabled by default like in version v.3.5.13.
PR argoproj/argo-workflows#13746 adds support to toggle workflowEvents. I set the default to true to not affect previous versions
There was a problem hiding this comment.
Thank you for the info, I didn't know that the default is true . then LGTM.
tico24
approved these changes
Jan 10, 2025
yu-croco
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: