Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-workflows): Support ephemeral credentials for s3 #3101

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

bmjhversteeg
Copy link
Contributor

In argoproj/argo-workflows#12467, support for ephemeral S3 credentials was added. These are used when using AWS S3 Grants or AWS IAM Roles. This PR adds support for the sessionTokenSecret field to the argo-workflows helm chart.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Bart Versteeg <8367621+bmjhversteeg@users.noreply.github.com>
@bmjhversteeg bmjhversteeg changed the title feat(argo-workflows) Support ephemeral credentials for s3 feat(argo-workflows): Support ephemeral credentials for s3 Jan 3, 2025
@yu-croco
Copy link
Collaborator

yu-croco commented Jan 3, 2025

📝 sessionTokenSecret is already released in v3.6.2
Ref: https://argo-workflows.readthedocs.io/en/latest/fields/#fields_70
image

Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM.

@tico24
Copy link
Member

tico24 commented Jan 3, 2025

@yu-croco 3.6 docs are here: https://argo-workflows.readthedocs.io/en/release-3.6/fields/ but you're still right :)

@tico24 tico24 merged commit 844afb6 into argoproj:main Jan 3, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants