Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-cd): Update dependency argoproj/argo-cd to v2.12.7 #3068

Closed
wants to merge 1 commit into from

Conversation

YaronL16
Copy link

@YaronL16 YaronL16 commented Dec 3, 2024

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: YaronL16 <lavyaron@gmail.com>
@tico24
Copy link
Member

tico24 commented Dec 3, 2024

12.13 is out and we don't backport to older versions I'm afraid.

@YaronL16
Copy link
Author

YaronL16 commented Dec 3, 2024

12.13 is out and we don't backport to older versions I'm afraid.

Yes but a new v2.12.x release dropped, why not include it in a chart?
After all like is mentioned in the documentation:

Helm charts are intended to be created for all non-patched releases of Argo CD, Workflows, Rollouts, and Events.

@jmeridth
Copy link
Member

jmeridth commented Dec 4, 2024

@YaronL16 once a new minor version is released, we don't create patches for previous versions. This has been a policy since I've been involved in this project. The maintenance involved exceeds our availability for that effort currently.

The workaround we've suggested in the past is for a user to point their chosen image tag in their values.yaml to the patched image. The only gotcha is if there are CRD changes in that patch version (usually rare).

I'm going to close this as it does not match our current policy. Thank you for your understanding and hope the workaround can work for you.

@YaronL16
Copy link
Author

YaronL16 commented Dec 4, 2024

@jmeridth

Okay got it, honestly don't really see why not to allow simple changes like this but I'll probably make the updated chart just for my team
Thanks

@argoproj argoproj locked and limited conversation to collaborators Dec 4, 2024
@argoproj argoproj unlocked this conversation Dec 4, 2024
@jmeridth
Copy link
Member

jmeridth commented Dec 4, 2024

@jmeridth

Okay got it, honestly don't really see why not to allow simple changes like this but I'll probably make the updated chart just for my team
Thanks

@YaronL16 are you volunteering to help us maintain patch level version updates from the upstream projects? All of them? We agree. It's easy for one. Or maybe a couple. But maintaining all of them requires more effort than we currently have to support it.

We do truly appreciate that you took time and created a pull request. We do not close it easily. We understand this PR could be a gateway to many more PRs. Is that what this is?

If you feel very strongly about this and are volunteering to take on the responsibility, especially since you believe it to be "simple changes", we can discuss it. If so, please start a thread in the CNCF slack in the #argo-helm-charts public channel and reference this PR.

Otherwise, thank you for your understanding and accepting of the current workarounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants