-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): Use renovate to create PRs when upstream releases #2358
Conversation
Signed-off-by: Tim Collins <tim@thecollins.team>
Hi - maybe we could also use this for dependencies or do we want to have renovate bot AND dependabot ? |
My dream would be to use this instead of dependabot long term, it's quite a lot better (IMO). But I'd like to roll it out reasonably gently so as to not rock the boat too much. |
Signed-off-by: Tim Collins <tim@thecollins.team>
Ah there's a bug. It's bumping the chart version and sticking a 'v' on the front. Leave that with me. edit: now resolved |
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM. Let's give this baby a try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🎉
oh boy..
So bad news first. this won't "just work". Someone with repo permissions will need to set up renovate, and probably polish off the final step of the github action (the one that pushes the changes back to the PR).z
Renovate should be available as an app for the repo, it was enabled for all argoproj projects to my knowedge.
What's all this then?
When set up, renovate will
it won't:
Renovate is only set to look at the Chart.yaml files. Here's all the dependencies it sees:
![image](https://private-user-images.githubusercontent.com/45351296/286270868-1e52a9f5-8b04-4f56-a9d1-37252ccf0ba5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjIwNjksIm5iZiI6MTczOTMyMTc2OSwicGF0aCI6Ii80NTM1MTI5Ni8yODYyNzA4NjgtMWU1MmE5ZjUtOGIwNC00ZjU2LWE5ZDEtMzcyNTJjY2YwYmE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAwNTYwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZiNGVjYzg3MDM2Zjc0MmRhYzMwMmNiMzc2Yjg3ZTE1NGE4ZTkyYTc5Y2Q0NDI1N2VjZWI2MTU4YjM3NTczOGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vcV7Kd3HL00dQzw8-_jt6wFDFE-ataPwxzFsqkB34ow)
(You can see in the above screenshot that it wants to bump workflows up a version.. I was using that for testing).
redis-ha
is disabled to prevent PRs appearing that will bump it above upstream.Once this is in, I'd strongly suggest enabling renovate on the
.github
directory. Some actions are out of date.Here's a screenshot of a test PR. All of this was automated:
Checklist: