feat: ArgoCDCommitStatus Kind #170

zachaller · 2025-01-03T20:24:23Z

No description provided.

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

…argocd-commitstatus-manager-kind

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

codecov-commenter · 2025-01-20T19:08:36Z

Codecov Report

Attention: Patch coverage is 67.62295% with 79 lines in your changes missing coverage. Please review.

Project coverage is 57.59%. Comparing base (8d94ce4) to head (7203ef1).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...ternal/controller/argocdcommitstatus_controller.go	67.62%	55 Missing and 24 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   54.23%   57.59%   +3.36%     
==========================================
  Files          10       11       +1     
  Lines        1263     1507     +244     
==========================================
+ Hits          685      868     +183     
- Misses        488      529      +41     
- Partials       90      110      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

…argocd-commitstatus-manager-kind

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

api/v1alpha1/argocdcommitstatus_types.go

internal/controller/argocdcommitstatus_controller.go

api/v1alpha1/argocdcommitstatus_types.go

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

internal/controller/argocdcommitstatus_controller.go

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

…argocd-commitstatus-manager-kind

crenshaw-dev · 2025-02-18T21:41:23Z

internal/controller/argocdcommitstatus_controller.go

+// TODO(user): Modify the Reconcile function to compare the state specified by
+// the ArgoCDCommitStatus object against the actual cluster state, and then
+// perform operations to make the cluster state reflect the state specified by
+// the user.
+//
+// For more details, check Reconcile and its Result here:
+// - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.19.1/pkg/reconcile


Remove boilerplate?

internal/controller/argocdcommitstatus_controller.go

crenshaw-dev · 2025-02-18T21:51:29Z

internal/controller/argocdcommitstatus_controller.go

+		}
+
+		if application.Spec.SourceHydrator == nil {
+			continue


Maybe just go ahead and throw an error? Would be consistent with how we handle non-matching repo URLs.

internal/controller/argocdcommitstatus_controller.go

docs/crd-specs.md

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

zachaller added 11 commits January 3, 2025 10:38

feat: new kind ArgoCDCommitStatus

7d90386

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

feat: start of kind

855af3e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

more work in progress

1efdc14

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lint

734bb1f

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

feat: wip adding argocd commit status controller

457bf98

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

feat: set owner ref

9293c1a

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: some cleanup

17e090d

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: some cleanup

134d950

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: lint

0efee07

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Merge branch 'main' of github.com:argoproj-labs/gitops-promoter into …

e7de27f

…argocd-commitstatus-manager-kind

chore: add path to tests

46cf4ee

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

zachaller added 6 commits January 20, 2025 13:11

chore: fix tests

45a7f7a

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: tidy

e49badc

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: codegen

8ab1b23

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Merge branch 'main' of github.com:argoproj-labs/gitops-promoter into …

6d4e56a

…argocd-commitstatus-manager-kind

chore: add applications selected

c7486f2

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: add applications selected sha and state

5080ec5

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

zachaller marked this pull request as ready for review January 21, 2025 00:12

zachaller added 3 commits January 20, 2025 18:13

chore: lint

c776e76

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: lint

e58fd44

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: lint

d9bd516

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

crenshaw-dev requested changes Jan 21, 2025

View reviewed changes

zachaller added 7 commits January 21, 2025 09:43

review 1

8df6841

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

switch to phase

c995697

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: add 5 second delay incase argocd flapps

d4309ca

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: fix lint

8f2d12e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: fix lint

1614a15

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: refactor

d22985a

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: lint

d8cf514

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

zachaller added 6 commits February 7, 2025 11:40

refactor to reduce Recocnile

82b9706

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

better names

f6d8540

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

better names

372daf3

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

better names

67b0e8c

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add docs on repo url matching

7ed4dcf

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add docs on repo url matching

27279d6

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

crenshaw-dev reviewed Feb 7, 2025

View reviewed changes

internal/controller/argocdcommitstatus_controller.go Outdated Show resolved Hide resolved

crenshaw-dev reviewed Feb 7, 2025

View reviewed changes

internal/controller/argocdcommitstatus_controller.go Outdated Show resolved Hide resolved

zachaller added 11 commits February 7, 2025 14:25

remove repo from aggregate key and check that all repos in apps match

aa40413

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

go tidy

28c994f

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

rename typo

f304a0b

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

better logs

6c0ed55

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

fix bad logic

550f03f

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lint

31e16e7

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

make sure created commit statuses are unique

a5dca2f

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lint

1bd61af

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

cleanup un-needed code

da10cb1

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

cleanup un-needed code

bf4e1dc

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Merge branch 'main' of github.com:argoproj-labs/gitops-promoter into …

8aa522d

…argocd-commitstatus-manager-kind

crenshaw-dev approved these changes Feb 18, 2025

View reviewed changes

zachaller and others added 7 commits February 18, 2025 15:58

Update docs/crd-specs.md

642d97b

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Update internal/controller/argocdcommitstatus_controller.go

81682be

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Update internal/controller/argocdcommitstatus_controller.go

7f34438

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Update internal/controller/argocdcommitstatus_controller.go

b575698

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Update internal/controller/argocdcommitstatus_controller.go

981e072

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: pr review

02818f7

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore: pr review

7203ef1

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

zachaller enabled auto-merge (squash) February 18, 2025 22:08

crenshaw-dev approved these changes Feb 18, 2025

View reviewed changes

zachaller merged commit fc33465 into argoproj-labs:main Feb 18, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ArgoCDCommitStatus Kind #170

feat: ArgoCDCommitStatus Kind #170

zachaller commented Jan 3, 2025

codecov-commenter commented Jan 20, 2025 •

edited

Loading

crenshaw-dev Feb 18, 2025

crenshaw-dev Feb 18, 2025

feat: ArgoCDCommitStatus Kind #170

feat: ArgoCDCommitStatus Kind #170

Conversation

zachaller commented Jan 3, 2025

codecov-commenter commented Jan 20, 2025 • edited Loading

Codecov Report

crenshaw-dev Feb 18, 2025

Choose a reason for hiding this comment

crenshaw-dev Feb 18, 2025

Choose a reason for hiding this comment

codecov-commenter commented Jan 20, 2025 •

edited

Loading