Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/various refactorings #68

Merged
merged 32 commits into from
Feb 11, 2025
Merged

Refactor/various refactorings #68

merged 32 commits into from
Feb 11, 2025

Conversation

piellardj
Copy link
Member

@piellardj piellardj commented Feb 9, 2025 •
edited
Loading

This PR:

  • contains optimizations of the IHeightmap.sampleHeightmap() API to use TypedArrays, which are more efficiently transferred
  • removes lots of unused code
  • explicitly names all threejs object to make debugging easier
  • contains various refactorings and renamings to harmonize vocabulary (chunk = 3D, patch = 2D)

@piellardj
feat: optimize IHeightmap.sampleHeightmap() API
021441e 
Float32Array are Transferrable and easily serializable so it is preferable
BREAKING CHANGE: IHeightmap API change
@piellardj
refactor: renaming
94205b5
@piellardj
refactor: extract class MaterialsStore
f7e29f7 
BREAKING CHANGE: VoxelmapViewer API change
@piellardj
fix: shader part
ebb71c9
@piellardj
feat: optimize IHeightmap.sampleHeightmap()
a4cc78d 
BREAKING CHANGE: IHeightmap API change
@piellardj
refactor: prefer Map to Record (1)
7998d67
@piellardj
refactor: delete unused code
e7404b6
@piellardj
refactor: prefer Map to Record (2)
7dd8d69
@piellardj
refactor: prefer Map to Record (3)
7b410b3
@piellardj
refactor: prefer Map to Record (4)
48213a7
@piellardj
refactor: prefer Map to Record (5)
cb0fb75
@piellardj
refactor: prefer Map to Record (6)
9f77030
@piellardj
refactor: prefer Map to Record (7)
83e8057
@piellardj
refactor: prefer Map to Record (8)
3875610
@piellardj
refactor: group altitude parameters
dd55ae9 
BREAKING CHANGE: IHeightmap and IVoxelmap changes
@piellardj
refactor: use ReadonlyArray when possible
c4c3bdc
@piellardj
refactor: prefer Iterable
9f2a6b2
@piellardj
refactor: name all THREE objects for easier debugging
a8e93b7
@piellardj
test: fix
f11c50d
@piellardj
refactor: extract interface IVoxelmapViewer
f50b0ab
@piellardj
refactor: remove VoxelmapViewerAutonomous
157c357
@piellardj
perf: optimize processing for empty chunks
355abfd
@piellardj
refactor: add PatchFactoryBase.maxPatchesComputedInParallel
d46d837
@piellardj
refactor: start renaming "patch" to "chunk"
d016719
@piellardj
refactor: remove mention to patch in VoxelsRenderable
6bcd662
@piellardj
refactor: move file
219ac50
@piellardj
refactor: finish renamings from "patch"->"chunk"
3ce1348 
BREAKING CHANGE: change VoxelmapViewer API
@piellardj
refactor: simplify buildChunkRenderable
f6c137c
@piellardj
refactor: extract type
e4a79be
@piellardj piellardj requested a review from Sceat February 9, 2025 19:44
@piellardj piellardj self-assigned this Feb 9, 2025
@piellardj piellardj mentioned this pull request Feb 9, 2025
Closed
@piellardj piellardj marked this pull request as draft February 10, 2025 12:10
@piellardj piellardj marked this pull request as ready for review February 10, 2025 12:28
@Sceat
Copy link
Member

Sceat commented Feb 11, 2025

/merge

@github-actions GitHub Actions
Copy link

Success! Fast forwarded master to refactor/various_refactorings! git checkout master && git merge refactor/various_refactorings --ff-only

@github-actions github-actions bot merged commit a859427 into master Feb 11, 2025
2 checks passed
@piellardj piellardj deleted the refactor/various_refactorings branch February 11, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sceat Sceat Sceat approved these changes

Assignees

@piellardj piellardj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piellardj @Sceat