Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/lod improvements #64

Merged
merged 21 commits into from
Jan 27, 2025
Merged

Feat/lod improvements #64

merged 21 commits into from
Jan 27, 2025

Conversation

piellardj
Copy link
Member

This PR contains improvements on the LOD:

  • reduce the CPU load on the main thread by offloading the computations to a dedicated worker thread
  • add the option to use flat shading (instead of smooth shading). Flat shading still looks cool, and removes the visual artifacts visible at the junction of LOD patches in smooth shading mode.

@piellardj
test: add UI to control LOD
270288b
@piellardj
feat: add support for flat shaded LOD
0a64d33
@piellardj
refactor: extract class GeometryProcessor
cbf9e40
@piellardj
perf: compute normals manually
092fe51
@piellardj
perf: delegate normals computation into dedicated worker
f2027b3
@piellardj
perf: minimize data copied between threads
f69dc64
@piellardj
perf: avoid inter-thread data copy whe possible
850763d
@piellardj
refactor: Worker, factorize code
e205439
@piellardj
fix: Worker, settle task in case of unexpected error
1e842fa
@piellardj
rerfactor: Worker, prefer Map to Record
78facc0
@piellardj
refactor: Worker, merge pending tasks stores
f6932e5 
No need to have one store per task type
@piellardj
fix: Worker, properly reject pending tasks if worker is terminated
705fcec
@piellardj
refactor: Worker, simplify messages
0dd1009
@piellardj
refactor: Worker, renamings
80ab925
@piellardj
refactor: Worker, dedicated ID system for messages
d3ab6fc 
To help debug
@piellardj
refactor: Worker, prepare for batch tasks processing
6c1d279
@piellardj
perf: Worker, allow sending tasks in batches
9cf445f
@piellardj
refactor: WorkerPool, simplify
dc7e228
@piellardj
refactor: Worker, simplify
2d9c786
@piellardj
refactor: Worker, extract method
a7e847a
@piellardj
perf: Worker, allow to send messages in batch :)
d5e09c0 
To minimize the communication CPU overhead when too many messages are sent.
@piellardj piellardj requested a review from Sceat January 26, 2025 19:55
@piellardj piellardj self-assigned this Jan 26, 2025
@Sceat
Copy link
Member

Sceat commented Jan 27, 2025

/merge

@github-actions GitHub Actions
Copy link

Success! Fast forwarded master to feat/lod_improvements! git checkout master && git merge feat/lod_improvements --ff-only

@github-actions github-actions bot merged commit d5e09c0 into master Jan 27, 2025
2 checks passed
@piellardj piellardj deleted the feat/lod_improvements branch January 27, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sceat Sceat Sceat approved these changes

Assignees

@piellardj piellardj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piellardj @Sceat