Initial clang-tidy linting

.clang-format

@@ -6,33 +6,48 @@ UseTab: Never
 ColumnLimit: 80
 ReflowComments: true
 AccessModifierOffset: -4
-SortIncludes: Never
 UseCRLF: false
 
 BreakBeforeBraces: Custom
 BraceWrapping:
-    AfterCaseLabel: true
-    AfterClass: true
-    AfterEnum: true
-    AfterFunction: true
-    AfterNamespace: true
-    AfterStruct: true
-    AfterUnion: true
-    AfterExternBlock: true
-    BeforeCatch: true
-    BeforeElse: true
-    BeforeLambdaBody: true
-    BeforeWhile: true
-    IndentBraces: false
-    SplitEmptyFunction: true
-    SplitEmptyRecord: true
-    SplitEmptyNamespace: true
+  AfterCaseLabel: true
+  AfterClass: true
+  AfterEnum: true
+  AfterFunction: true
+  AfterNamespace: true
+  AfterStruct: true
+  AfterUnion: true
+  AfterExternBlock: true
+  BeforeCatch: true
+  BeforeElse: true
+  BeforeLambdaBody: true
+  BeforeWhile: true
+  IndentBraces: false
+  SplitEmptyFunction: true
+  SplitEmptyRecord: true
+  SplitEmptyNamespace: true
 BreakBeforeBinaryOperators: None
 BreakBeforeTernaryOperators: true
 BreakInheritanceList: AfterComma
 SeparateDefinitionBlocks: Always
 AlwaysBreakTemplateDeclarations: Yes
 
+SortIncludes: true
+IncludeBlocks: Regroup
+IncludeCategories:
+  - Regex: '^"radiant/TotallyRad.h"'
+    Priority: 0
+    SortPriority: 0
+  - Regex: '^"radiant/.*\.h"'
+    Priority: 0
+    SortPriority: 1
+  - Regex: '^".*\.h"$'
+    Priority: 1
+    SortPriority: 2
+  - Regex: '^<.*>$'
+    Priority: 1
+    SortPriority: 3
+
 BinPackArguments: false
 BinPackParameters: false
 AllowAllArgumentsOnNextLine: false
@@ -41,13 +56,13 @@ ReferenceAlignment: Left
 AlignAfterOpenBracket: Align
 AlignArrayOfStructures: Right
 AlignConsecutiveBitFields:
-    Enabled: true
-    AcrossEmptyLines: false
-    AcrossComments: true
+  Enabled: true
+  AcrossEmptyLines: false
+  AcrossComments: true
 AlignConsecutiveMacros:
-    Enabled: true
-    AcrossEmptyLines: false
-    AcrossComments: true
+  Enabled: true
+  AcrossEmptyLines: false
+  AcrossComments: true
 AlignEscapedNewlines: Right
 AlignOperands: Align
 IndentCaseBlocks: false

.clang-tidy

@@ -0,0 +1,3 @@
+---
+Checks: '-*'
+WarningsAsErrors: '*'

.github/workflows/lint.yaml

@@ -25,5 +25,7 @@ jobs:
           cache-dependency-path: ./tools/rad/setup.py
       - name: Install Rad Tool
         run: pip install -e ./tools/rad
+      - name: Initialize
+        run: rad init
       - name: Run Linter
         run: rad lint --all-files --skip no-commit-to-branch

.pre-commit-config.yaml

@@ -13,6 +13,7 @@ repos:
     rev: 9a9bbc00895bbdb7670231c2565d4f1309c42905  # v1.3.5
     hooks:
       - id: clang-format
+        args: [-i]
   - repo: https://github.com/psf/black
     rev: ec91a2be3c44d88e1a3960a4937ad6ed3b63464e  # 23.12.1
     hooks:
@@ -29,3 +30,12 @@ repos:
         language: system
         types: [python]
         require_serial: true
+  - repo: local
+    hooks:
+      - id: clang-tidy
+        name: clang-tidy
+        entry: rad
+        args: [lint, --clang-tidy]
+        language: python
+        files: \.(c|cc|cpp|cxx|h|hh|hpp|hxx|)$
+        require_serial: true

BUILD.bazel

@@ -1,10 +1,16 @@
+load("@hedron_compile_commands//:refresh_compile_commands.bzl", "refresh_compile_commands")
+
 package(default_visibility = ["//visibility:public"])
 
 exports_files([
     "AUTHORS",
     "LICENSE",
 ])
 
+refresh_compile_commands(
+    name = "refresh_compile_commands",
+)
+
 config_setting(
     name = "msvc",
     flag_values = {

MODULE.bazel

@@ -25,7 +25,7 @@ bazel_dep(name = "hedron_compile_commands", dev_dependency = True)
 git_override(
     module_name = "hedron_compile_commands",
     remote = "https://github.com/hedronvision/bazel-compile-commands-extractor.git",
-    commit = "a14ad3a64e7bf398ab48105aaa0348e032ac87f8",
+    commit = "4f28899228fb3ad0126897876f147ca15026151e",
 )
 
 # Windows - allows building with the EWDK, must set EWDKDIR environment variable

radiant/.clang-tidy

@@ -0,0 +1,8 @@
+---
+InheritParentConfig: true
+Checks:
+  - misc-include-cleaner
+  - llvm-include-order
+  - performance-*
+  - portability-*
+  - -performance-enum-size

radiant/Algorithm.h

@@ -14,9 +14,6 @@
 
 #pragma once
 
-#include "radiant/TotallyRad.h"
-#include "radiant/TypeTraits.h"
-#include "radiant/Utility.h"
 #include "radiant/TotallyRad.h"
 
 namespace rad

radiant/Atomic.h

@@ -15,8 +15,11 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
+#include "radiant/TypeTraits.h"
 #include "radiant/detail/AtomicIntrinsics.h"
 
+#include <stddef.h>
+
 namespace rad
 {
 

radiant/EmptyOptimizedPair.h

@@ -14,7 +14,6 @@
 
 #pragma once
 
-#include "radiant/TotallyRad.h"
 #include "radiant/Utility.h"
 
 namespace rad

radiant/Integer.h

@@ -13,8 +13,10 @@
 // limitations under the License.
 
 #include "radiant/TotallyRad.h"
-#include "radiant/TypeTraits.h"
 #include "radiant/Res.h"
+#include "radiant/TypeTraits.h"
+
+#include <stdint.h>
 
 namespace rad
 {

radiant/Iterator.h

@@ -14,9 +14,11 @@
 
 #pragma once
 
-#include "radiant/TotallyRad.h"
+#include "radiant/TypeTraits.h"
 #include "radiant/Utility.h"
 
+#include <stddef.h>
+
 namespace rad
 {
 

radiant/Res.h

@@ -17,6 +17,8 @@
 #include "radiant/TotallyRad.h"
 #include "radiant/Result.h"
 
+#include <stdint.h>
+
 namespace rad
 {
 

radiant/Result.h

@@ -15,9 +15,13 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
+#include "radiant/TypeTraits.h"
 #include "radiant/TypeWrapper.h"
 
+#include <stdint.h>
+#if RAD_ENABLE_STD
 #include <initializer_list>
+#endif
 
 namespace rad
 {

radiant/ScopeExit.h

@@ -15,7 +15,8 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
-#include "radiant/Utility.h"
+#include "radiant/TypeTraits.h"
+#include "radiant/Utility.h" // NOLINT(misc-include-cleaner)
 
 namespace rad
 {

radiant/SharedPtr.h

@@ -15,10 +15,14 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
-#include "radiant/Memory.h"
 #include "radiant/Atomic.h"
-#include "radiant/Locks.h"
 #include "radiant/EmptyOptimizedPair.h"
+#include "radiant/Locks.h"  // NOLINT(misc-include-cleaner)
+#include "radiant/Memory.h" // NOLINT(misc-include-cleaner)
+#include "radiant/TypeTraits.h"
+#include "radiant/detail/AtomicIntrinsics.h"
+
+#include <stdint.h>
 
 namespace rad
 {

radiant/Span.h

@@ -15,8 +15,12 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
-#include "radiant/Iterator.h"
 #include "radiant/Byte.h"
+#include "radiant/Iterator.h"
+#include "radiant/TypeTraits.h"
+
+#include <stddef.h>
+#include <stdint.h>
 
 namespace rad
 {

radiant/TotallyRad.h

@@ -154,10 +154,19 @@ static_assert(!(RAD_WINDOWS && RAD_MACOS), "env invalid os");
 
 #define RAD_UNUSED(x) ((void)x)
 
-#include <stdint.h>
+#ifdef RAD_MSC_VERSION
+// MSVC does not seem to have something like __has_builtin, but
+// also seems to define a superset of what the other compilers do
+// in terms of intrinsics
+#define RAD_HAS_BUILTIN(v) 1
+#else
+#define RAD_HAS_BUILTIN(v) __has_builtin(v)
+#endif
 
-#if RAD_WINDOWS && RAD_KERNEL_MODE
-#include <wdm.h>
+#if RAD_WINDOWS
+#define RAD_YIELD_PROCESSOR() YieldProcessor()
+#else
+#define RAD_YIELD_PROCESSOR() sched_yield()
 #endif
 
 #define RAD_CONCAT_INNER(x, y) x##y

radiant/TypeTraits.h

@@ -17,6 +17,8 @@
 #include "radiant/TotallyRad.h"
 #include "radiant/detail/StdTypeTraits.h"
 
+#include <stdint.h>
+
 namespace rad
 {
 

radiant/TypeWrapper.h

@@ -15,6 +15,7 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
+#include "radiant/TypeTraits.h"
 #include "radiant/Utility.h"
 
 #if RAD_ENABLE_STD

radiant/UniqueResource.h

@@ -15,7 +15,8 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
-#include "radiant/Utility.h"
+#include "radiant/TypeTraits.h"
+#include "radiant/Utility.h" // NOLINT(misc-include-cleaner)
 
 namespace rad
 {

radiant/Utility.h

@@ -17,6 +17,8 @@
 #include "radiant/TotallyRad.h"
 #include "radiant/TypeTraits.h"
 
+#include <stdint.h>
+
 namespace rad
 {
 

radiant/Vector.h

@@ -15,10 +15,17 @@
 #pragma once
 
 #include "radiant/TotallyRad.h"
-#include "radiant/Memory.h"
 #include "radiant/EmptyOptimizedPair.h"
+#include "radiant/Memory.h"
+#include "radiant/Res.h"
+#include "radiant/Span.h"
 #include "radiant/detail/VectorOperations.h"
 
+#include <stdint.h>
+#if RAD_ENABLE_STD
+#include <initializer_list>
+#endif
+
 namespace rad
 {