Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial clang-tidy linting #29

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Initial clang-tidy linting #29

merged 1 commit into from
Oct 12, 2024

Conversation

jxy-s
Copy link
Collaborator

@jxy-s jxy-s commented Oct 12, 2024

This PR introduces clang-tidy linting to the project. There is currently some limitations on Mac that will be sorted out in the future. Linux and Windows gives equivalent results. Linux clang-tidy is a requirement to merge. For now we're conservative on the checkers we enable and hope to add more checkers in the future.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (b2f29bf) to head (331cd29).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   90.23%   89.79%   -0.44%     
==========================================
  Files          18       17       -1     
  Lines        1977     1980       +3     
  Branches      257      262       +5     
==========================================
- Hits         1784     1778       -6     
  Misses         13       13              
- Partials      180      189       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxy-s
Copy link
Collaborator Author

jxy-s commented Oct 12, 2024

Release build broke on main despite there being zero code changes since that last successful run 4 days ago. Will investigate and fix in a separate PR.

@jxy-s jxy-s merged commit d3abe0f into main Oct 12, 2024
15 of 16 checks passed
@jxy-s jxy-s deleted the lint-clang-tidy branch October 12, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant