From a5360b7ea20c6fc4e86bf29c257abeea8f5de377 Mon Sep 17 00:00:00 2001 From: Johnny Shaw Date: Mon, 3 Jun 2024 18:27:43 -0600 Subject: [PATCH 1/4] test on ARM64 GitHub runners --- .github/workflows/unit-tests.yaml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml index d33e767..c3f7374 100644 --- a/.github/workflows/unit-tests.yaml +++ b/.github/workflows/unit-tests.yaml @@ -25,6 +25,19 @@ jobs: repository-cache: true - name: Build and Run Unit Tests run: bazel test --test_output=all //... + Linux-ARM64: + runs-on: archonite-linux-arm64 + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: Setup Bazel + uses: bazel-contrib/setup-bazel@0.8.2 + with: + bazelisk-cache: true + disk-cache: ${{ github.workflow }} + repository-cache: true + - name: Build and Run Unit Tests + run: bazel test --test_output=all //... Mac: runs-on: macos-latest steps: @@ -53,3 +66,18 @@ jobs: # extra slash is an intentional hack, powershell converts a // to / run: bazel test --test_output=all ///... shell: bash + Windows-ARM64: + runs-on: archonite-windows-arm64 + steps: + - name: Checkout + uses: actions/checkout@v4 + - name: Setup Bazel + uses: bazel-contrib/setup-bazel@0.8.2 + with: + bazelisk-cache: true + disk-cache: ${{ github.workflow }} + repository-cache: true + - name: Build and Run Unit Tests + # extra slash is an intentional hack, powershell converts a // to / + run: bazel test --test_output=all ///... + shell: bash From 3461f978870608c098e8e78901383070256f6351 Mon Sep 17 00:00:00 2001 From: Johnny Shaw Date: Tue, 4 Jun 2024 11:40:04 -0600 Subject: [PATCH 2/4] update setup-bazel version --- .github/workflows/build.yaml | 4 ++-- .github/workflows/code-coverage.yaml | 2 +- .github/workflows/unit-tests.yaml | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 6ae52eb..b0e7437 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -18,7 +18,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} @@ -31,7 +31,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} diff --git a/.github/workflows/code-coverage.yaml b/.github/workflows/code-coverage.yaml index 57fe37c..0e3ba26 100644 --- a/.github/workflows/code-coverage.yaml +++ b/.github/workflows/code-coverage.yaml @@ -18,7 +18,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml index c3f7374..faaecad 100644 --- a/.github/workflows/unit-tests.yaml +++ b/.github/workflows/unit-tests.yaml @@ -18,7 +18,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} @@ -31,7 +31,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} @@ -44,7 +44,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} @@ -57,7 +57,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} @@ -72,7 +72,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.2 + uses: bazel-contrib/setup-bazel@0.8.5 with: bazelisk-cache: true disk-cache: ${{ github.workflow }} From d0e0c0af96af9b204e02e2d4475a007b85254734 Mon Sep 17 00:00:00 2001 From: Johnny Shaw Date: Tue, 4 Jun 2024 12:54:36 -0600 Subject: [PATCH 3/4] switch to cmd instead of bash for Windows CI --- .github/workflows/unit-tests.yaml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml index faaecad..48ceb7e 100644 --- a/.github/workflows/unit-tests.yaml +++ b/.github/workflows/unit-tests.yaml @@ -63,9 +63,8 @@ jobs: disk-cache: ${{ github.workflow }} repository-cache: true - name: Build and Run Unit Tests - # extra slash is an intentional hack, powershell converts a // to / - run: bazel test --test_output=all ///... - shell: bash + run: bazel test --test_output=all //... + shell: cmd Windows-ARM64: runs-on: archonite-windows-arm64 steps: @@ -78,6 +77,5 @@ jobs: disk-cache: ${{ github.workflow }} repository-cache: true - name: Build and Run Unit Tests - # extra slash is an intentional hack, powershell converts a // to / - run: bazel test --test_output=all ///... - shell: bash + run: bazel test --test_output=all //... + shell: cmd From 28855cc974e4cc90e9ebf6811c882cd9492e9d71 Mon Sep 17 00:00:00 2001 From: Johnny Shaw Date: Tue, 4 Jun 2024 13:05:10 -0600 Subject: [PATCH 4/4] disable Windows ARM64 CI pending bazelisk support --- .github/workflows/unit-tests.yaml | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml index 48ceb7e..43ac3ad 100644 --- a/.github/workflows/unit-tests.yaml +++ b/.github/workflows/unit-tests.yaml @@ -65,17 +65,20 @@ jobs: - name: Build and Run Unit Tests run: bazel test --test_output=all //... shell: cmd - Windows-ARM64: - runs-on: archonite-windows-arm64 - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: Setup Bazel - uses: bazel-contrib/setup-bazel@0.8.5 - with: - bazelisk-cache: true - disk-cache: ${{ github.workflow }} - repository-cache: true - - name: Build and Run Unit Tests - run: bazel test --test_output=all //... - shell: cmd + # Disabled until the following are resolved: + # https://github.com/bazel-contrib/setup-bazel/issues/25 + # https://github.com/bazelbuild/bazelisk/issues/572 + #Windows-ARM64: + # runs-on: archonite-windows-arm64 + # steps: + # - name: Checkout + # uses: actions/checkout@v4 + # - name: Setup Bazel + # uses: bazel-contrib/setup-bazel@0.8.5 + # with: + # bazelisk-cache: true + # disk-cache: ${{ github.workflow }} + # repository-cache: true + # - name: Build and Run Unit Tests + # run: bazel test --test_output=all //... + # shell: cmd