fix: Fix string resource not found

Fix for string resource not found for string id -1 returned by the viewModel when in no error scenario. Signed-off-by: Archit Raj <arch10@ymail.com>
arch10 · Feb 21, 2021 · ca1417a · ca1417a
1 parent e432efa
commit ca1417a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -17,7 +17,7 @@ android {
         applicationId "com.gigaworks.tech.calculator"
         minSdkVersion 21
         targetSdkVersion 30
-        versionCode 42
+        versionCode 44
         versionName "2.0.0"
         buildConfigField "java.util.Date", "buildTime", "new java.util.Date(" + System.currentTimeMillis() + "L)"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"

diff --git a/app/src/main/java/com/gigaworks/tech/calculator/ui/main/MainActivity.kt b/app/src/main/java/com/gigaworks/tech/calculator/ui/main/MainActivity.kt
@@ -196,7 +196,11 @@ class MainActivity : BaseActivity<ActivityMainBinding>() {
                     val shake = AnimationUtils.loadAnimation(this, R.anim.shake)
                     getResultEditText().setTextColor(getResultTextColor(true))
                     val errorStringId = viewModel.error.value ?: R.string.invalid
-                    setResult(getString(errorStringId))
+                    if (errorStringId == -1) {
+                        setResult("")
+                    } else {
+                        setResult(getString(errorStringId))
+                    }
                     getResultEditText().startAnimation(shake)
                 } else {
                     val balancedExpression = viewModel.getCalculatedExpression()