More Automatic Compliance with the format. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… leven, iftype, and data2. This is reflected in the documentation under the section Setter rules. New unit-tests to complement these changes. This now means that sac-format *should not* be capable of writing corrupted sac-files due to user error. Next update will include tests to ensure it cannot output malformed sac-files due to user error.
…iles being written.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 2 2
Lines 1196 1241 +45
=======================================
+ Hits 1195 1240 +45
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Npts, leven, iftype, data1, and data2 are all linked together as defined in the SAC format specification.
Their relationships to each other have been added to the documentation to prevent confusion.
WIth this, sac-format is now unable to create malformed sac-files due to user error.
Note that this does not mean that dependent parameters change as data changes (xminimum/xmaximum, depmen, depmin, depmax, etc... are all untouched). This decision is to avoid unnecessary computations. In the future it would be good to have functions that calculate these values, which the user can call manually.